Review 13.4 Merged

87693[TASK] Ensure decorated `Connection->transactional()` method works

Stefan Bürk CR +2 V +2 Normal +196 −0 updated 01/10/25, 13:15

Commit message

TYPO3 decorates the `\Doctrine\DBAL\Connection` class with the custom
implementation `\TYPO3\CMS\Core\Database\Connection` and uses is as
the default connection managed by the `ConnectionPool`.

The `transactional()` method is not used by TYPO3 directly yet while
extension developers have a valid interest in a working state of the
simplified transaction handling.

This change adds some tests to ensure that simplified `transactional()`
handling works and adds the method to the decoracted class along with
a inline phpdocblock override to satisfy PHPStan revealed by the tests.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Stefan Bürk commented on patch set 1 01/10/25, 13:07

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/10/25, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72209

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 01/10/25, 13:15

  4. Stefan Bürk merged patch set 2 01/10/25, 13:15