Review 13.4 Merged

87707[TASK] Close any open modal in InstallTool Cest tear-down

Benni Mack CR +2 V +2 Easy +14 −26 updated 01/13/25, 11:30

Commit message

This closes any open modal in InstallTool Cest tear-down.
Thereby especially the click on 'logout' in tear-down will always work.
A modal might stay open in case the preceding test fails midway.

This makes it unnecessary to close the modal in the test-cases
itselves.

Otherwise the error reporting for the non-working click on 'logout'
might overlay the actual error.

This depends on `step_decorators: \Codeception\Step\TryTo` which is
available in `main` and `13.4`.

This implements `DataProviders` for `Application\SettingsCest`. Thereby
any flash-messages or modals from in between the test-cases are
automatically closed via `_before`/`_after`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Benni Mack commented on patch set 1 01/13/25, 10:44

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/13/25, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72309

  3. Benni Mack voted on patch set 1 CR +2 V +2 01/13/25, 11:30

  4. Benni Mack merged patch set 2 01/13/25, 11:30