Review 13.4 Merged

87709[BUGFIX] flatpickr: handle proper validation of altInput

Andreas Kienast CR +2 V +2 Easy +11 −2 updated 01/13/25, 11:40

Commit message

flatpickr builds an alternative input field for user interaction if
enabled (which we do) to separate UI date format from system date
formats.
This adds a new layer of complexity in terms of validation: the event
`formengine.dp.change` was dispatched on the original input field, which
is the one being hidden by flatpickr, causing inproper validation of
date picker fields.

The validity state of the validated input field needs to be synchronized
with the `altInput` generated by flarpickr, therefore a custom handler
for the event `t3-formengine-postfieldvalidation` is registered.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast commented on patch set 1 01/13/25, 11:22

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/13/25, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72317

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 01/13/25, 11:39

  4. Andreas Kienast merged patch set 2 01/13/25, 11:40