87718[!!!][TASK] Throw specific exception in Folder->getSubFolder()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Mathias Brodala +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Mathias Brodala +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/core/Classes/Resource/Folder.php3+5 −3
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-105920-Folder-getSubFolderThrowsFolderDoesNotExistException.rstnew+81 −0
- typo3/sysext/core/Tests/Unit/Resource/FolderTest.php+12 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/AbstractGenerator.php+3 −2
Review log 1114
-
Christian Kuhn uploaded patch set 1 01/13/25, 13:52
-
Mathias Brodala commented on patch set 1 01/13/25, 13:55
-
core-ci voted on patch set 1 V +1 01/13/25, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72353
-
Christian Kuhn commented on patch set 1 01/13/25, 14:04
Folder.php:257Replythat's true. that's why this is a WIP and i think it should go to v14 only, i wanted to see if CI finds something else, first. i'll now add a .rst and explain the impact. -
Christian Kuhn uploaded patch set 2
V +101/13/25, 14:26 -
core-ci voted on patch set 2 V +1 01/13/25, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72355
-
Christian Kuhn updated the commit message in patch set 3
V +101/13/25, 14:39 -
Christian Kuhn commented on patch set 2 01/13/25, 14:39
Folder.php:257ReplyDone -
Mathias Brodala voted on patch set 3 CR +1 01/13/25, 14:44
-
core-ci voted on patch set 3 V +1 01/13/25, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72356
-
Mathias Brodala voted on patch set 3 V +1 01/13/25, 15:00
-
Stefan Bürk voted on patch set 3 CR +1 V +1 01/13/25, 15:02
-
Christian Kuhn voted on patch set 3 CR +2 V +2 01/13/25, 15:42
-
Christian Kuhn merged patch set 4 01/13/25, 15:42
Folder.php:257