Issue Bug Closed

#96727ExistingTargetFolderException not handled correctly

Michael Grundkötter 02/02/22, 09:57 updated 12/02/25, 14:33

Description

In `TYPO3\CMS\Core\Resource\ResourceStorage::getNestedProcessingFolder` there is this code:

foreach ($nestedFolderNames as $folderName) {
    if ($processingFolder->hasFolder($folderName)) {
        $processingFolder = $processingFolder->getSubfolder($folderName);
    } else {
        $currentEvaluatePermissions = $processingFolder->getStorage()->getEvaluatePermissions();
        $processingFolder->getStorage()->setEvaluatePermissions(false);
        $processingFolder = $processingFolder->createFolder($folderName);
        $processingFolder->getStorage()->setEvaluatePermissions($currentEvaluatePermissions);
    }
}

and the call to `$processingFolder->createFolder()` can cause an ExistingTargetFolderException, which may be caused by parallel actions of multiple editors or whatever. Although the issue seem to be handled by `$processingFolder->hasFolder($folderName)` right above, the exception does occur in our sentry system nevertheless. Hence, this code block should be changed like this instead to prevent the process from terminating completely:

foreach ($nestedFolderNames as $folderName) {
    if ($processingFolder->hasFolder($folderName)) {
        $processingFolder = $processingFolder->getSubfolder($folderName);
    } else {
        $currentEvaluatePermissions = $processingFolder->getStorage()->getEvaluatePermissions();
        $processingFolder->getStorage()->setEvaluatePermissions(false);
        try {
            $processingFolder = $processingFolder->createFolder($folderName);
            $processingFolder->getStorage()->setEvaluatePermissions($currentEvaluatePermissions);
        } catch (ExistingTargetFolderException $existingTargetFolderException) {
            $processingFolder = $processingFolder->getSubfolder($folderName);
        }
    }
}

Reviews 4

History 616

  1. Mathias Brodala commented <span data-processor="relativetime" data-value="2024-07-04T10:41:29+00:00" > 07/04/24, 10:41 </span>

    We see the same issue by using ichhabrecht/filefill. Here it is expected that files and folders are created by parallel requests.

  2. Mathias Brodala commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2025-01-14T18:30:08+00:00" > 01/14/25, 18:30 </span>

    Applied in changeset commit:03027a9cb4c558284289da7007c225aa42a72619.