Review 13.4 Merged

87770[BUGFIX] Close modal windows containing an iframe on escape

Oli Bartsch CR +2 V +2 Normal +65 −1 updated 01/15/25, 09:26

Commit message

Currently, modal windows are not closed when the escape button is
pressed while the focus is within the iframe.

This behavior has been fixed by closing the modal once the user hits
escape even then the focus is within the iframe.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Oli Bartsch commented on patch set 1 01/15/25, 09:13

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/15/25, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72509

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 01/15/25, 09:26

  4. Oli Bartsch merged patch set 2 01/15/25, 09:26