Review 13.4 Merged

87777[BUGFIX] Fix behavior and styling of EXT:form element type listing

Benjamin Franzke CR +2 V +2 Easy +20 −10 updated 01/16/25, 09:05

Commit message

With #104901, the migration from <a> to <button> the JavaScript
handlers were not updated to accommodate the new markup,
preventing proper insertion of elements into form creating with EXT:form.

Additionally, the styling was misaligned for elements and page types
in the form.

This patch restores the correct visual styling for the element list and
updates the JavaScript handlers to ensure compatibility with the new
button-based markup.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 6

Review log 34

  1. Benjamin Franzke commented on patch set 1 01/16/25, 08:29

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 01/16/25, 08:31

  3. core-ci voted on patch set 1 V +1 01/16/25, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72550

  4. Benjamin Franzke merged patch set 2 01/16/25, 09:05