Review 12.4 Merged

87782[BUGFIX] Gracefully handle invalid punycode domains in URI parsing

Benjamin Franzke CR +2 V +2 Easy +29 −1 updated 01/17/25, 07:54

Commit message

URLs may contain hostnames that look like punycode, but contain
invalid chars. `idn_to_ascii` reports `false` in this case.
The Hostname is therefore to be interpreted as ascii and can be passed
to `filter_var` for validation without modification.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 01/16/25, 16:06

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/16/25, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72571

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 01/17/25, 07:54

  4. Benjamin Franzke merged patch set 2 01/17/25, 07:54