Review 13.4 Merged

87801[BUGFIX] Remove ColumnDiff overwrite to support doctrine/dbal 4.2.2

Benjamin Franzke CR +2 V +2 Normal +8 −134 updated 01/17/25, 19:35

Commit message

The doctrine `Doctrine/DBAL 4.2.2` [1] release includes a change to
consider column platform options as changed to support PostgreSQL
`JSONB`.

The newly introduced method `ColumnDiff::hasPlatformOptionsChanged()`
tries to access the private properties `newColumn` and `oldColumn`
which are not accessible in the TYPO3 extended `ColumnDiff` class.
This extended class replaced these private properties by publicly
modifiable ones. This lead to a TypeError during the database compare
for PostgreSQL with Doctrine DBAL 4.2.2.

To mitigate this issue object composition instead of object
modification is used to apply quoting to the ColumnDiff oldColumn
without the need for a custom ColumnDiff implementation.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Benjamin Franzke commented on patch set 1 01/17/25, 19:23

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 01/17/25, 19:28

  3. core-ci voted on patch set 1 V +1 01/17/25, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72638

  4. Benjamin Franzke merged patch set 2 01/17/25, 19:35