Review 13.4 Merged

87803[BUGFIX] Set Symfony Finder "ignoreUnreadableDirs" option

Garvin Hicking CR +2 V +2 Easy +10 −8 updated 01/18/25, 09:01

Commit message

In some cases, directories without read permissions (like "lost+found")
may occur in a TYPO3 instance directory tree.

By default the Symfony Finder throws an exception and thus makes
the whole process fail, instead of skipping unreadable site config
directories for example.

With this patch, all places of the Symfony Finder usage
will utilize "ignoreUnreadableDirs()" in calls where possibly
unreadable directories should be skippable.

(Note that typo3/sysext/core/Classes/Package/PackageManager.php
utilized this option before, too.)

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 34

  1. Garvin Hicking commented on patch set 1 01/18/25, 08:45

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/18/25, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72656

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 01/18/25, 09:01

  4. Garvin Hicking merged patch set 2 01/18/25, 09:01