Review 13.4 Merged

87861[BUGFIX] Respect order of item groups in NewContentElementWizard

Garvin Hicking CR +2 V +2 Hard +274 −7 updated 01/23/25, 11:48

Commit message

Since the change of registering wizard items groups with TCA in #102834
the order of groups can't be changed anymore in the wizard.

This is addressed now with a rather simple solution: When TCA groups are
added, the sorting is already ensured by EMU:addTcaSelectItemGroup. We
take this sorting and auto-add the positional information in
NewContentElementController by list-linking the groups by
"after:{theGroupBefore}". This way the sorting is well-defined.

How to deal with PageTs: Well, we can't have it both ways. As soon
as PageTs overrides at least one group order, this will overrule the
TCA sorting. Then, everything has to be defined via PageTs. This is
fine, as we strive to reduce usage of PageTs.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 69

  1. Garvin Hicking commented on patch set 1 01/23/25, 09:18

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php
  2. Garvin Hicking commented on patch set 2 01/23/25, 09:19

    Published edit on patch set 1.
  3. core-ci voted on patch set 2 V -1 01/23/25, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72909

  4. core-ci voted on patch set 1 V -1 01/23/25, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72908

  5. Nikita Hovratov uploaded patch set 3 V -1 01/23/25, 10:51

  6. core-ci voted on patch set 3 V +1 01/23/25, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72920

  7. Garvin Hicking marked it ready for review 01/23/25, 11:34

  8. Garvin Hicking voted on patch set 3 CR +2 V +2 01/23/25, 11:48

  9. Garvin Hicking merged patch set 4 01/23/25, 11:48