Review 13.4 Merged

87882[BUGFIX] Re-allow saving nullable \DateTime properties as null

Benni Mack CR +2 V +2 Normal +94 −3 updated 01/28/25, 07:26

Commit message

If an entity property is a nullable \DateTime, which is also marked
nullable via TCA and which is stored as a DATETIME in the database,
a nulled property must be stored as null.

Currently, all null values are converted to 0000-00-00 00:00:00, which
is not only invalid but also not the desired value.

This change restores the former behaviour.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 8

Review log 58

  1. Benni Mack commented on patch set 1 01/25/25, 18:54

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php * typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMap.php * typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMapFactory.php
  2. core-ci voted on patch set 1 V -1 01/25/25, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73001

  3. Alexander Schnitzler uploaded patch set 2 V -1 01/27/25, 19:06

  4. Alexander Schnitzler uploaded patch set 3 01/27/25, 19:12

  5. core-ci voted on patch set 2 V -1 01/27/25, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73066

  6. core-ci voted on patch set 3 V +1 01/27/25, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73067

  7. Benni Mack commented on patch set 3 CR +2 V +2 01/28/25, 07:26

    This change is ready for review.
    Hey Alex, thanks a lot - forgot to fix the patch set right away, and left it there. Thanks for helping out here!
  8. Benni Mack merged patch set 4 01/28/25, 07:26