87882[BUGFIX] Re-allow saving nullable \DateTime properties as null
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMap.php+12 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMapFactory.php+1 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+10 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/DateExample.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_dateexample.php+1 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Fixtures/BackendTest/getPlainValueReturnsNullForNullableDateTimePropertyAssertion.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Fixtures/BackendTest/getPlainValueReturnsNullForNullableDateTimePropertyImport.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/BackendTest.phpnew+63 −0
Review log 58
-
Benni Mack commented on patch set 1 01/25/25, 18:54
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php * typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMap.php * typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMapFactory.php -
core-ci voted on patch set 1 V -1 01/25/25, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73001
-
Alexander Schnitzler uploaded patch set 2
V -101/27/25, 19:06 -
Alexander Schnitzler uploaded patch set 3 01/27/25, 19:12
-
core-ci voted on patch set 2 V -1 01/27/25, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73066
-
core-ci voted on patch set 3 V +1 01/27/25, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73067
-
Benni Mack commented on patch set 3 CR +2 V +2 01/28/25, 07:26
This change is ready for review.Hey Alex, thanks a lot - forgot to fix the patch set right away, and left it there. Thanks for helping out here! -
Benni Mack merged patch set 4 01/28/25, 07:26