Review 13.4 Merged

87937[BUGFIX] Use new selectItem syntax with assoc array

Benni Mack CR +2 V +2 Easy +14 −15 updated 01/30/25, 07:42

Commit message

This change adapts the itemsProcFunc for
"index_config" to use "label", "value" and "icon"
instead of the old numeric syntax for select items.

At the same time, in order to demonstrate
best practices, DI and Schema API is used.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 01/30/25, 07:31

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/30/25, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73185

  3. Benni Mack voted on patch set 1 CR +2 V +2 01/30/25, 07:42

  4. Benni Mack merged patch set 2 01/30/25, 07:42