Review 13.4 Merged

87944[BUGFIX] Correct Workspace Preview

Andreas Kienast CR +2 V +2 Hard +162 −233 updated 01/30/25, 15:55

Commit message

This patch addresses multiple issues with the
workspace preview.

The visibility of the range slider is now restored
by correcting the markup to be used as intended.
The labels were never meant to be placed inside
`.form-range`, as it is only a wrapper for styling
the element. Additionally, the labels are now
properly hidden when the preview is not in slide
mode. To better align with the buttons,
`.form-range-sm` is added to ensure a similar
appearance in size.

The calculation of the element’s height was invalid,
preventing it from being set to 0 or 100%. The
calculation and surrounding CSS were rewritten to
allow a simpler implementation based on percentages
instead of fixed pixel. This enables the view to
better adapt to viewport changes without requiring
recalculations.

The top bar was reorganized for improved behavior
on mobile devices, consuming less space and
providing more room for the preview. To minimize
layout shifts, the view mode switch and action
buttons are now aligned to the end of the top bar.

The CSS was modernized to simplify adjustments and
respect the user's preference for light and dark
mode in the top bar.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 34

  1. Andreas Kienast commented on patch set 1 01/30/25, 15:48

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/30/25, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73204

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 01/30/25, 15:55

  4. Andreas Kienast merged patch set 2 01/30/25, 15:55