Review 13.4 Merged

88004[BUGFIX] Prevent array to string conversion in backend password reset

Georg Ringer CR +2 V +2 Easy +3 −5 updated 02/03/25, 19:01

Commit message

Submitting an array instead of a string in the backend password
reset form triggers a warning and 503 error due to
`GeneralUtility::validEmail()` function expecting a string.

This change ensures, that the submitted email address in the
password reset form is always treated as a string. If a
non-string value is detected, it will be safely reset to an
empty string.

Additionally, one unused variable and two superfluous doc
comments have been removed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Georg Ringer commented on patch set 1 02/03/25, 18:37

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/03/25, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73438

  3. Georg Ringer voted on patch set 1 CR +2 V +2 02/03/25, 19:01

  4. Georg Ringer merged patch set 2 02/03/25, 19:01