Review 13.4 Merged

88025[BUGFIX] Improve Context Menu Accessibility

Benjamin Kott CR +2 V +2 Expert +690 −459 updated 02/05/25, 07:54

Commit message

This patch addresses several issues within the context menu.

The context menu has been rewritten as a reactive web component.
All entries are now managed as a dataset within the component,
with only the node itself used internally. This significantly
improves reliability and simplifies handling by eliminating the
need to parse the markup again to retrieve information.

Clicking outside the menu now consistently closes it. To achieve
this, the element rendering was moved to the top frame, and an
invisible layer acts as a trigger for closing the menu. This layer
spans both the main frame and the content frame, allowing clicks
outside the menu to pass through and initiate new interactions.

Menu items are now structured correctly as a menu, with proper
positioning, setsize, and ARIA labels. The left arrow key now only
closes submenus and no longer closes the context menu when the
selected element is at the root level.

Instead of <li> elements, <button> elements are now used, and
acceptance tests have been adapted accordingly.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 2

Files 14

Review log 34

  1. Benjamin Kott commented on patch set 1 02/05/25, 07:27

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/05/25, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73556

  3. Benjamin Kott voted on patch set 1 CR +2 V +2 02/05/25, 07:54

  4. Benjamin Kott merged patch set 2 02/05/25, 07:54