Review 13.4 Merged

88094[TASK] Dynamically limit livesearch to searchFields used in subtypes

Benni Mack CR +2 V +2 Hard +259 −17 updated 02/07/25, 22:27

Commit message

Previously, the bodytext field, for example, was only searched
if the CType was text, textpic or textmedia. This condition is
unknown to practically all developers which has been spoken to.
The only exception so far seems to be the `EXT:mask` extension,
which already dynamically extends this condition.

It was introduced with TYPO3 v4.6 with #26829 and was pretty
much untouched ever since.

With the introduction of the TCA Schema API, we can handle the
issue much more generically for all tables with subtypes. We
can thus make the search much more precise and only search in
fields that actually exist in the respective subtype like the
CType for example.

The purpose of this search restriction is to ensure that, for
example, the content in the bodytext field is no longer found
if it was filled as a text element and then changed to a plugin.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 34

  1. Benni Mack commented on patch set 1 02/07/25, 22:19

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/07/25, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73778

  3. Benni Mack voted on patch set 1 CR +2 V +2 02/07/25, 22:27

  4. Benni Mack merged patch set 2 02/07/25, 22:27