Review 13.4 Merged

88151[BUGFIX] Fix fetchType in InternalLinktype

Benni Mack CR +2 V +2 Easy +28 −1 updated 02/10/25, 20:32

Commit message

InternalLinktype::fetchType returns a type, even if the link
type is of type file. The following link types are
mutually exclusive:

- "db" => InternalLinktype
- "file" => FileLinktype

InternalLinktype does not check file links, so it should not
return "db" link type for file links. It only checks page
links.

Also, clarification was added in the comments to make this
clearer.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 02/10/25, 20:23

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/10/25, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73933

  3. Benni Mack voted on patch set 1 CR +2 V +2 02/10/25, 20:32

  4. Benni Mack merged patch set 2 02/10/25, 20:32