Review 13.4 Merged

88152[TASK] Use ForwardResponse instead of redirect in indexed search

Garvin Hicking CR +2 V +2 Easy +3 −2 updated 02/10/25, 20:56

Commit message

When TypoScript config is missing for EXT:indexed_search,
the extbase action handling uses a redirect to
`noTypoScriptAction`, which changes the URI of a request
to point to that action.

When fixing the TypoScript configuration, a page reload
will thus still show the same error, resulting in a bad
developer experience.

By using a ForwardResponse() instead, the same output
can be displayed without a change of the URI.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Garvin Hicking commented on patch set 1 02/10/25, 20:24

    Cherry Picked from branch main.
  2. Benni Mack updated the commit message in patch set 2 02/10/25, 20:27

  3. core-ci voted on patch set 1 V +1 02/10/25, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73934

  4. core-ci voted on patch set 2 V +1 02/10/25, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73936

  5. Georg Ringer voted on patch set 2 CR +2 V +2 02/10/25, 20:56

  6. Georg Ringer merged patch set 3 02/10/25, 20:56