Review 13.4 Merged

88233[BUGFIX] Prevent recycler failure when allowDelete=0 is set

Garvin Hicking CR +2 V +2 Easy +12 −12 updated 02/17/25, 09:54

Commit message

Setting the user TSconfig option `mod.recycler.allowDelete=0`
lead to the recycler's backend module showing a javascript
error that an undefined HTML DOM element (mass delete button)
cannot be removed.

The check whether the mass delete should be created in the
DOM is performed in the fluid section `multiRecordSelectionActions`
of `RecyclerModule.html`. Because of this, there is no
need to try to remove this in the DOM dynamically.

The whole conditional block is now removed, because the other
functionality it provided was to set a `display: block`
attribute on the mass delete buttons, which is also already part of
the regular DOM.

Two other checks on the existance of the DOM mass delete element
are now changed so that `TYPO3.settings.Recycler.deleteDisable` is
evaluated instead.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Garvin Hicking commented on patch set 1 02/16/25, 16:59

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/16/25, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74205

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 02/17/25, 09:54

  4. Garvin Hicking merged patch set 2 02/17/25, 09:54