Review 13.4 Merged

88238[BUGFIX] Fix failing image generation for width/height 0 thumbnails

Georg Ringer CR +2 V +2 Normal +45 −14 updated 02/16/25, 19:00

Commit message

Extreme image dimensions like 1920x10 pixels will yield a height=0
in case a 64x64 thumbnail area shall be created.

In these cases, a width/height of 1 should be enforced.

Even though these generated images will not be very helpful to look
at, they must allow image generation to continue working.

As a drive-by, this also ensures integer
values for width/height specified through $options
and mentions the option array key naming in comments.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 4

Files 2

Review log 34

  1. Georg Ringer commented on patch set 1 02/16/25, 18:38

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/16/25, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74211

  3. Georg Ringer voted on patch set 1 CR +2 V +2 02/16/25, 19:00

  4. Georg Ringer merged patch set 2 02/16/25, 19:00