Review 13.4 Merged

88249[BUGFIX] Revert "[BUGFIX] Fix site set label loading on windows"

Benjamin Franzke CR +2 V +2 Easy +13 −37 updated 02/17/25, 11:59

Commit message

This reverts commit a84d9ddd305fad3db7e22341faf012b37bb56526.

Reason for revert:
Until v13.4.4 a backend module title could be loaded from a slightly
invalid config in `Configuration/Backend/Modules.php` like:

```
'labels' => 'LLL:EXT:myext/…/locallang.xlf:my.title'
```

Although `'labels'` is supposed to contain a file reference only
(like `LLL:EXT:myext/Resources/Private/Language/locallang.xlf`)
the example above worked because TYPO3 built a language key named
`LLL:EXT:myext/…/locallang.xlf:my.title:mlang_tabs_tab`
where `:mlang_tabs_tab` then was ignored by the LLL: parser in
`LanguageService`, because it implicitly ignores everything after
the second colon after `LLL:EXT:`.

That means we can not assume that the language key is listed after
the last colon, as existing (undefined) behaviour silently ignored
gratuitous colon-suffixes. Multiple public extensions where found
that use this approach, therefore we revert this change and plan
to fix windows site label loading using another approach. (#106164)

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 02/17/25, 11:43

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/17/25, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74253

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 02/17/25, 11:54

  4. Benjamin Franzke merged patch set 2 02/17/25, 11:59