Review 13.4 Merged

88251[TASK] Enable TypeScript `noImplicitOverride` option

Benjamin Franzke CR +2 V +2 Hard +367 −359 updated 02/17/25, 12:09

Commit message

Enforce declaration of the `override` keyword for methods or
properties that override members of a base class, to ensure
that base classes and extending classes never get "out of sync".

See also: https://www.typescriptlang.org/tsconfig/#noImplicitOverride

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 118

Show 98 more files

Review log 34

  1. Benjamin Franzke commented on patch set 1 02/17/25, 12:01

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 02/17/25, 12:03

  3. core-ci voted on patch set 1 V +1 02/17/25, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74255

  4. Benjamin Franzke merged patch set 2 02/17/25, 12:09