Review 13.4 Merged

88265[BUGFIX] Fix RootLevel capability

Benni Mack CR +2 V +2 Easy +32 −10 updated 02/18/25, 14:55

Commit message

The Schema API introduction used the API in a wrong
way, thus, evaluating [ctrl][rootLevel] = 1 and
[ctrl][rootLevel] = 0.

This is now corrected and a test is added.

https://docs.typo3.org/m/typo3/reference-tca/13.4/en-us/Ctrl/#confval-ctrl-rootlevel

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 79

  1. Benni Mack commented on patch set 1 02/18/25, 14:38

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php * typo3/sysext/workspaces/Classes/Service/WorkspaceService.php
  2. Benni Mack commented on patch set 2 02/18/25, 14:39

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 02/18/25, 14:39

  4. Benni Mack rebased onto patch set 3 02/18/25, 14:41

  5. Benni Mack uploaded patch set 4 02/18/25, 14:41

  6. core-ci voted on patch set 4 V +1 02/18/25, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74324

  7. core-ci voted on patch set 2 V -1 02/18/25, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74322

  8. Benni Mack voted on patch set 4 CR +2 V +2 02/18/25, 14:55

  9. Benni Mack merged patch set 5 02/18/25, 14:55