Review main Ready for review

88283[BUGFIX] Calculate local rootline correctly

Jigal van Hemert CR 0 V +1 Easy +36 −3 updated 11/09/26, 20:28

Commit message

In case there are multiple sys_template records in a page and one is
marked as root all these templates will be checked now. Earlier only
one of the templates was stored in the sysTemplateRowsIndexedByPid
array for each page.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/83/88283/4 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/83/88283/4 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V +1 Needs a vote
    • Oliver Klee +1
    • core-ci +1 CI

Merge conflicts 1

Issues 1

Files 3

Review log 59

  1. Jigal van Hemert uploaded patch set 1 02/19/25, 20:24

  2. core-ci voted on patch set 1 V -1 02/19/25, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74412

  3. Jigal van Hemert rebased onto patch set 2 V -1 03/28/25, 09:32

  4. core-ci voted on patch set 2 V -1 03/28/25, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76561

  5. Benni Mack updated the commit message in patch set 3 V -1 04/22/26, 06:25

  6. core-ci voted on patch set 3 V -1 04/22/26, 06:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100691

  7. Georg Ringer uploaded patch set 4 V -1 11/09/26, 20:12

  8. core-ci voted on patch set 4 V +1 11/09/26, 20:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113776

  9. Oliver Klee voted on patch set 4 V +1 11/09/26, 20:28