Review 12.4 Merged

88288[BUGFIX] Except when 'renderType' is not string in NodeFactory

Garvin Hicking CR +2 V +2 Easy +6 −0 updated 02/20/25, 08:23

Commit message

In cases where `array_merge_recursive` is used to append
to a TCA configuration multiple times with the same
key, it will lead to transforming an array key with
a single value to an array of values instead.

The NodeFactory can not deal with this case.

This patch throws an exception in case no string
is found, and tries to hint at this possible
array scenario.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Garvin Hicking commented on patch set 1 02/19/25, 21:57

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/19/25, 22:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74422

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 02/20/25, 08:23

  4. Garvin Hicking merged patch set 2 02/20/25, 08:23