Review 13.4 Merged

88300[TASK] Enable TypeScript `noUnusedLocals` option

Benjamin Franzke CR +2 V +2 Normal +20 −65 updated 02/20/25, 12:27

Commit message

Disallow unused variables or unused private methods to reduce
the level of code smell in our codebase.

See also: https://www.typescriptlang.org/tsconfig/#noUnusedLocals

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 34

  1. Benjamin Franzke commented on patch set 1 02/20/25, 12:04

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/20/25, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74466

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 02/20/25, 12:27

  4. Benjamin Franzke merged patch set 2 02/20/25, 12:27