Review 13.4 Merged

88405[TASK] Enable most TypeScript strict-mode options

Benjamin Franzke CR +2 V +2 Easy +16 −10 updated 02/28/25, 15:16

Commit message

We can not yet enable strictNullChecks [1] (>2000 errors),
but three other sub-options of the `strict` [2] flag are
now being enabled, where only a minimum amount of changes
are needed:

 * `strictBindCallApply` (2 changes)
 * `useUnknownInCatchVariables` option (3 changes)
 * `strictBuiltinIteratorReturn` (0 changes)

[1] https://www.typescriptlang.org/tsconfig/#strictNullChecks
[2] https://www.typescriptlang.org/tsconfig/#strict

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 34

  1. Benjamin Franzke commented on patch set 1 02/28/25, 14:45

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/28/25, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74902

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 02/28/25, 15:16

  4. Benjamin Franzke merged patch set 2 02/28/25, 15:16