Review 12.4 Merged

88433[BUGFIX] Fix pagination of reactions and webhooks module

Oli Bartsch CR +2 V +2 Easy +14 −14 updated 03/03/25, 08:41

Commit message

This fixes the pagination implementations, used
in the reactions and the webhooks module, which
are basically the same code base.

When filtering the "all count" is now properly
calculated preventing that the pagination is
always displayed even if there are only a
subset of records available.

The pagination refresh button now actually
refreshes the current paginated page.

A duplicated records object is removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 34

  1. Oli Bartsch commented on patch set 1 03/03/25, 08:28

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 03/03/25, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74993

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 03/03/25, 08:41

  4. Oli Bartsch merged patch set 2 03/03/25, 08:41