Review 13.4 Merged

88476[BUGFIX] Read RTE options as string and array

Garvin Hicking CR +2 V +2 Normal +66 −66 updated 03/04/25, 13:03

Commit message

EXT:rte_ckeditor was introduced in TYPO3v8
with a configuration based on YAML. With this,
most options were given in array format, but
because of backwards compatibility to
TSConfig, a lot of options are still also
interpreted as string format.

However, a few options were missing to be
made compatible for both kinds of specification,
either via YAML or TSConfig.

Options like "keepTags", "denyTags", "range" and
"list" (for `fixAttrib`) are now checked for string
and array.

Also, "always=1" is cast to string now to
prevent error in `strtoupper()`.

Converting all values of "list" array to upper
case will now use `array_map` instead of
`array_walk` to prevent calling
`strtoupper` with wrong argument counts.

The tests introduced with #106189 are now
enabled to verify this fixed behaviour.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 6

Review log 34

  1. Garvin Hicking commented on patch set 1 03/04/25, 11:30

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 03/04/25, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75094

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 03/04/25, 13:03

  4. Garvin Hicking merged patch set 2 03/04/25, 13:03