Review 13.4 Abandoned

88548[TASK] Use Schema API in NewContentElementController

Benni Mack CR 0 V 0 Hard +372 −413 updated 03/22/25, 16:42

Commit message

This change uses Schema API in NewContentElement
Controller, but also streamlines some tests
and their filenames.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 712

  1. Benni Mack commented on patch set 1 03/10/25, 10:23

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php * typo3/sysext/backend/Tests/Functional/Controller/ContentElement/NewContentElementWizardControllerTest.php * typo3/sysext/backend/Tests/Unit/Controller/ContentElement/NewContentElementControllerTest.php
  2. Benni Mack commented on patch set 2 03/10/25, 10:23

    Published edit on patch set 1.
  3. Benni Mack commented on patch set 3 03/10/25, 10:24

    Published edit on patch set 2.
  4. core-ci voted on patch set 1 V -1 03/10/25, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75401

  5. core-ci voted on patch set 3 V -1 03/10/25, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75403

  6. core-ci voted on patch set 2 V -1 03/10/25, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75402

  7. Benni Mack rebased onto patch set 4 V -1 03/11/25, 08:29

  8. core-ci voted on patch set 4 V -1 03/11/25, 08:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75462

  9. Georg Ringer commented on patch set 4 03/14/25, 07:57

    This change is ready for review.
  10. Benni Mack uploaded patch set 5 V -1 03/21/25, 20:42

  11. core-ci voted on patch set 5 V -1 03/21/25, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75986

  12. Benni Mack abandoned the change 03/22/25, 16:42

    won't do due to list_type etc.