Review 13.4 Merged

88549[BUGFIX] Avoid layout shifts when dragging content blocks in Page module

Benjamin Kott CR +2 V +2 Normal +141 −69 updated 03/10/25, 12:25

Commit message

We now use appropriate move icons to indicate the desired actions and
visualize this in the tooltip. Previously, information about pressing
"Control" to copy an element instead of moving it caused layout shifts.
This issue arose because the information was not migrated correctly and
was previously attached to the drag preview.

With the adoption of the new DragTooltip API, we ensure a more natural
behavior. Instead of displaying the help text, we update the cursor and
status icon in the tooltip to reflect the desired action. This approach
aligns with the standard behavior on operating systems.

Additionally, the detection of whether a copy action is requested has
been adjusted to work with the Option key on macOS. This is now also
properly forwarded to the modal to actually perform the requested action.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 2

Files 17

Review log 58

  1. Benjamin Kott commented on patch set 1 03/10/25, 10:38

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 03/10/25, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75404

  3. Benjamin Kott commented on patch set 2 V +1 03/10/25, 11:46

    Cherry Picked from branch main.
  4. core-ci voted on patch set 2 V +1 03/10/25, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75408

  5. Benjamin Kott commented on patch set 3 V +1 03/10/25, 12:13

    Cherry Picked from branch main.
  6. core-ci voted on patch set 3 V +1 03/10/25, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75414

  7. Benjamin Kott voted on patch set 3 CR +2 V +2 03/10/25, 12:24

  8. Benjamin Kott merged patch set 4 03/10/25, 12:25