Review 12.4 Merged

88578[BUGFIX] Prevent array to string conversion in backend password reset

Benjamin Franzke CR +2 V +2 Easy +3 −4 updated 03/12/25, 13:51

Commit message

Submitting an array instead of a string in the backend password
reset form triggers a warning and 503 error due to
`GeneralUtility::validEmail()` function expecting a string.

This change ensures the submitted email address in the
password reset form is always treated as a string. If a
non-string value is detected, it will be safely reset to an
empty string.

Additionally, one unused variable and two superfluous doc
comments have been removed.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 58

  1. Benjamin Franzke commented on patch set 1 03/12/25, 07:45

    Cherry Picked from branch 13.4.
  2. Benjamin Franzke uploaded patch set 2 03/12/25, 07:47

  3. core-ci voted on patch set 2 V +1 03/12/25, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75508

  4. core-ci voted on patch set 1 V -1 03/12/25, 07:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75507

  5. Oliver Klee updated the commit message in patch set 3 V +1 03/12/25, 08:06

  6. core-ci voted on patch set 3 V +1 03/12/25, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75509

  7. Benjamin Franzke voted on patch set 3 CR +2 V +2 03/12/25, 12:30

  8. Benjamin Franzke merged patch set 4 03/12/25, 13:51