88611[TASK] Use abstract docs.typo3.org linking service method
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Lina Wolf +1
-
Verified V +2 Done
- Georg Ringer +2
- Lina Wolf +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1621
-
Garvin Hicking uploaded patch set 1 03/17/25, 08:44
-
Lina Wolf commented on patch set 1 CR +1 03/17/25, 08:49
Looks like a good solution to me -
core-ci voted on patch set 1 V +1 03/17/25, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75697
-
Garvin Hicking commented on patch set 1 CR -1 03/17/25, 08:55
doing some rework -
Garvin Hicking uploaded patch set 2
CR +1V +103/17/25, 09:10 -
Garvin Hicking commented on patch set 2 03/17/25, 09:11
Reply
Done. Used more DI now, and fixed URL_OPCACHE. -
core-ci voted on patch set 2 V -1 03/17/25, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75698
-
Garvin Hicking uploaded patch set 3
V -103/17/25, 09:51 -
core-ci voted on patch set 3 V +1 03/17/25, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75704
-
Mathias Brodala commented on patch set 3 03/17/25, 12:38
Typo3Information.php:33This should be private since there is no value in directly accessing this. -
Garvin Hicking commented on patch set 3 03/17/25, 14:24
Typo3Information.php:33ReplyI thought it might be good for reusability in possible foreign components, and would follow the lead of the other variables above, as some kind of "forward compatbility". I don't think gating this privately would be hurtful? -
Lina Wolf commented on patch set 3 CR +1 03/17/25, 14:56
Typo3Information.php:33ReplyI would also suggest to leave it public -
Garvin Hicking commented on patch set 4
CR +1V +103/17/25, 18:18Published edit on patch set 3. -
Garvin Hicking commented on patch set 4 03/17/25, 18:19
Typo3Information.php:33Replydue to popular demand I will change this. We'll make it public then if it's needed I guess ¯\_(ツ)_/¯ -
core-ci voted on patch set 4 V -1 03/17/25, 18:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75731
-
Garvin Hicking commented on patch set 5
V -103/17/25, 18:35Published edit on patch set 4. -
core-ci voted on patch set 5 V +1 03/17/25, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75732
-
Georg Ringer voted on patch set 5 CR +1 V +1 03/17/25, 18:45
-
Lina Wolf voted on patch set 5 CR +1 V +1 03/18/25, 07:19
-
Georg Ringer voted on patch set 5 CR +2 V +2 03/18/25, 07:23
-
Georg Ringer merged patch set 6 03/18/25, 07:23