Review main Merged

88611[TASK] Use abstract docs.typo3.org linking service method

Garvin Hicking CR +2 V +2 Easy +23 −10 updated 03/18/25, 07:23

Commit message

The DocumentationViewHelper contains logic to be able to link
to typo3.docs.org with specific versioning information. This
logic was not available to other areas in the PHP scope of
the core.

With this patch, this logic is put into the Typo3Information
DO, where other similar URLs are already listed.

This allows to have one central place to adjust documentation
URLs and the DocumentationViewHelper can now utilize this via:

```
$url = (new Typo3Information())
  ->getDocsLink('changelog:important-106192-1739862406');
```

(or using dependency injection)

As a drive-by, the URL_OPCACHE contents have been adjusted
and usage of existing instances is enforced.
Note that DI is not possible within the ViewHelper because
it is used in Install-Tool context that does not provide full DI.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Lina Wolf +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1621

  1. Garvin Hicking uploaded patch set 1 03/17/25, 08:44

  2. Lina Wolf commented on patch set 1 CR +1 03/17/25, 08:49

    Looks like a good solution to me
  3. core-ci voted on patch set 1 V +1 03/17/25, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75697

  4. Garvin Hicking commented on patch set 1 CR -1 03/17/25, 08:55

    doing some rework
  5. Garvin Hicking uploaded patch set 2 CR +1 V +1 03/17/25, 09:10

  6. Garvin Hicking commented on patch set 2 03/17/25, 09:11

    Reply

    Done. Used more DI now, and fixed URL_OPCACHE.
  7. core-ci voted on patch set 2 V -1 03/17/25, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75698

  8. Garvin Hicking uploaded patch set 3 V -1 03/17/25, 09:51

  9. core-ci voted on patch set 3 V +1 03/17/25, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75704

  10. Mathias Brodala commented on patch set 3 03/17/25, 12:38

    Typo3Information.php:33

    This should be private since there is no value in directly accessing this.
  11. Garvin Hicking commented on patch set 3 03/17/25, 14:24

    Typo3Information.php:33 Reply

    I thought it might be good for reusability in possible foreign components, and would follow the lead of the other variables above, as some kind of "forward compatbility". I don't think gating this privately would be hurtful?
  12. Lina Wolf commented on patch set 3 CR +1 03/17/25, 14:56

    Typo3Information.php:33 Reply

    I would also suggest to leave it public
  13. Garvin Hicking commented on patch set 4 CR +1 V +1 03/17/25, 18:18

    Published edit on patch set 3.
  14. Garvin Hicking commented on patch set 4 03/17/25, 18:19

    Typo3Information.php:33 Reply

    due to popular demand I will change this. We'll make it public then if it's needed I guess ¯\_(ツ)_/¯
  15. core-ci voted on patch set 4 V -1 03/17/25, 18:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75731

  16. Garvin Hicking commented on patch set 5 V -1 03/17/25, 18:35

    Published edit on patch set 4.
  17. core-ci voted on patch set 5 V +1 03/17/25, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75732

  18. Georg Ringer voted on patch set 5 CR +1 V +1 03/17/25, 18:45

  19. Lina Wolf voted on patch set 5 CR +1 V +1 03/18/25, 07:19

  20. Georg Ringer voted on patch set 5 CR +2 V +2 03/18/25, 07:23

  21. Georg Ringer merged patch set 6 03/18/25, 07:23