Review 13.4 Merged

88757[BUGFIX] Elevate tree starting points to abstract class

Georg Ringer CR +2 V +2 Normal +21 −31 updated 03/25/25, 20:58

Commit message

The event `ModifyTreeDataEvent` accepts any tree of type
`AbstractTableConfigurationTreeDataProvider`. However, the only existing
event listener treats the tree as of type `DatabaseTreeDataProvider` by
using its `$startingPoints` attribute, which breaks as soon the event
`ModifyTreeDataEvent` is dispatched with another tree implementation
that is compatible with `AbstractTableConfigurationTreeDataProvider`.

To solve this, the `$startingPoints` and its getter/setter have been
moved to the abstract class, which also fixes one ignored phpstan issue.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Georg Ringer commented on patch set 1 03/25/25, 20:34

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 03/25/25, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76313

  3. Georg Ringer voted on patch set 1 CR +2 V +2 03/25/25, 20:58

  4. Georg Ringer merged patch set 2 03/25/25, 20:58