Review 13.4 Merged

88783[BUGFIX] Properly respect multi-part altLabelField in DB Check

Georg Ringer CR +2 V +2 Normal +81 −28 updated 03/27/25, 06:09

Commit message

In case TCA definitions set a 'label_alt' value with multiple
fields (like `tt_content` with `subheader,bodytext`) then the
DB Check will not be able to resolve value selections for
query parts (e.g. the select dropdown to allow picking tt_content
records for the parts of the query).

Additional problems came up when a relation like `CType` is
defined as 'label_alt' and not properly resolved.

This patch also addresses some side-effects of the TCA Schema
API integration of #106156:

- Repeated record row header labels
- Problems resolving "uid" when selected (not part of Schema API
  `->getField()`)
- Wrong `$outString` placement leading to unneeded linebreaks
- Combined two identical occurrences of code into a helper method
  `evaluateRelationDisplayWithLabels`
- Missing type-safety check for "labels_noprefix" option

See forge ticket for steps to reproduce.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Georg Ringer commented on patch set 1 03/27/25, 05:12

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 03/27/25, 05:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76423

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 03/27/25, 06:09

  4. Garvin Hicking merged patch set 2 03/27/25, 06:09