Review main Merged

88817[TASK] Restore removed `BackendUtility::resolveFileReferences()` tests

Stefan Bürk CR +2 V +2 Normal +101 −0 updated 03/28/25, 08:35

Commit message

Method `BackendUtility::resolveFileReferences()` has been deprecated
with #106446 and tests has been moved to `RemoteServerTests`, where
the code has been moved internally.

We still need to ensure that the deprecated public method works and
tests should be kept and only removed along with the deprecated code.

This change restores the test for the deprecated method, adding the
`#[IgnoreDeprecations]` to mitigate failing test execution related
to emitted `E_USER_DEPRECATED` error.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Stefan Bürk uploaded patch set 1 03/28/25, 07:23

  2. Georg Ringer commented on patch set 1 CR +1 03/28/25, 07:26

    sorry for forgetting about it and thanks for taking care!
  3. core-ci voted on patch set 1 V +1 03/28/25, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76552

  4. Benni Mack commented on patch set 1 CR +1 V +1 03/28/25, 07:56

    thanks!
  5. Garvin Hicking voted on patch set 1 CR +1 V +1 03/28/25, 08:19

  6. Georg Ringer voted on patch set 1 CR +2 V +2 03/28/25, 08:35

  7. Georg Ringer merged patch set 2 03/28/25, 08:35