Review 13.4 Merged

88915[TASK] Mitigate phpstan issue early with `doctrine/dbal 4.3.x`

Stefan Bürk CR +2 V +2 Easy +2 −4 updated 04/02/25, 11:55

Commit message

Upcoming `doctrine/dbal 4.3.x` adds additional PHP DocBlocks to
narrow down array shapes and would be caught up by our nightlies
when the version is released.

`TYPO3\CMS\Core\Tests\Functional\Database\Schema\SchemaMigratorTest`
contains checks on the array representation of a `Column` explicitly
testing for the existence of the `default` key in the array, which
is already ensured since `doctrine/dbal 4.0.0`. Not providing any
value to be tested, array key checks are removed or replaced as small
early mitigation and preventing of failing nightly when the new version
is released.

Tested and extracted from `doctrine/dbal 4.3.x` test change,
see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88596

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 04/02/25, 11:43

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/02/25, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76878

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 04/02/25, 11:55

  4. Stefan Bürk merged patch set 2 04/02/25, 11:55