Review 13.4 Merged

88967[BUGFIX] Use "allowed" option for TCA type=group in Extbase

Benni Mack CR +2 V +2 Normal +39 −13 updated 04/08/25, 08:28

Commit message

Extbase needed to have a "foreign_table" property in
TCA type=group records, in order to deal with
relations. This has been an issue since many versions,
and is now fixed by using the first entry of "allowed",
which is the documented setting for type=group.

This means, that Extbase developers do not need
to set "foreign_table" on TCA type=group anymore!

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 3

Files 2

Review log 57

  1. Benni Mack commented on patch set 1 04/07/25, 19:56

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMapFactory.php
  2. Benni Mack uploaded patch set 2 04/07/25, 20:01

  3. core-ci voted on patch set 2 V +1 04/07/25, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77163

  4. core-ci voted on patch set 1 V -1 04/07/25, 20:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77162

  5. Benni Mack marked it ready for review 04/08/25, 08:27

  6. Benni Mack voted on patch set 2 CR +2 V +2 04/08/25, 08:28

  7. Benni Mack merged patch set 3 04/08/25, 08:28