Review 13.4 Merged

88992[BUGFIX] Provide memcache object to close method

Stefan Bürk CR +2 V +2 Easy +2 −1 updated 04/09/25, 09:16

Commit message

The `close` function requires the memcache object as 1st argument if
using as procedural API, see https://www.php.net/manual/en/memcache.close.php

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Stefan Bürk commented on patch set 1 04/08/25, 21:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/08/25, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77240

  3. Stefan Bürk commented on patch set 1 CR -1 04/08/25, 21:51

    see main change - -1 until comment is resolved / changed (and backport eventually updated and -1 cleared anyway).
  4. Stefan Bürk commented on patch set 2 CR -1 V +1 04/09/25, 07:12

    Published edit on patch set 1.
  5. core-ci voted on patch set 2 V +1 04/09/25, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77261

  6. Georg Ringer voted on patch set 2 CR +2 V +2 04/09/25, 09:16

  7. Georg Ringer merged patch set 3 04/09/25, 09:16