Review 13.4 Merged

89033[TASK] Enhance blog_example extbase test with frontend editing

Garvin Hicking CR +2 V +2 Expert +969 −44 updated 04/10/25, 10:40

Commit message

Currently, the core has no functional test coverage of
basic "CRUD" forms using extbase:

* Listing of domain model records
* View details of single record
* Edit single record
* Save single record
* Create new record
* Utilize form validation

This is needed to also showcase localisation issues
and create future tests.

This test also reveals an issue with Guzzle's
`build()` method not supporting array with more
than 2 levels of depth. When needing this,
the `http_build_query` native PHP method can be
used, and a variant for this is added to
`InternalRequestDataMappingTest`.

This test also updates Extbase annotations.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 3

Files 20

Review log 46

  1. Garvin Hicking commented on patch set 1 04/10/25, 09:33

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 04/10/25, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77418

  3. Garvin Hicking uploaded patch set 2 V -1 04/10/25, 10:31

    Adjust to CType
  4. core-ci voted on patch set 2 V +1 04/10/25, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77429

  5. Garvin Hicking voted on patch set 2 CR +2 V +2 04/10/25, 10:40

  6. Garvin Hicking merged patch set 3 04/10/25, 10:40