Review 13.4 Merged

89069[BUGFIX] Prevent file selection via name link when denied by IsFileSelectableEvent

Benni Mack CR +2 V +2 Easy +6 −2 updated 04/11/25, 16:48

Commit message

When a file is marked as non-selectable using IsFileSelectableEvent, the
file browser correctly removes the '+' icon and checkboxes. However, the
file could still be selected by clicking on the file name.

This patch ensures that when a file is not selectable, the attribute
`data-filelist-action` is not set, and the button is instead disabled.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 04/11/25, 16:33

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/11/25, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77561

  3. Benni Mack voted on patch set 1 CR +2 V +2 04/11/25, 16:48

  4. Benni Mack merged patch set 2 04/11/25, 16:48