Review 13.4 Merged

89089[BUGFIX] Generate proper file path for ImageResource objects

Stefan Bürk CR +2 V +2 Easy +12 −13 updated 04/12/25, 18:57

Commit message

While refactoring "imgInfo" in #102755 (which was the
ugly array list of 0,1,2,3) into a DTO called
"ImageResource", an error was made to send a manually
calculated full path from
Environment::getPublicPath() . '/' . $processedFile->getPublicUrl()
into the DTO.

This is obviously wrong, as getPublicUrl() can be referenced
by e.g. the full URL via Events etc.

FAL offers the full path by providing $file->getForLocalProcessing()
to have a real local path.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 04/12/25, 18:46

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/12/25, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77640

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 04/12/25, 18:57

  4. Stefan Bürk merged patch set 2 04/12/25, 18:57