Review 13.4 Merged

89154[BUGFIX] Introduce GridColumn Form element to prevent Fieldset misusage

Benjamin Kott CR +2 V +2 Normal +139 −1 updated 04/17/25, 10:56

Commit message

While Fieldset could be repurposed to define columns in
GridRows, its primary role within forms carries semantic
significance and requires a legend for proper accessibility.
Using Fieldset purely for visual structure risks misinforming
assistive technologies and disrupting user experience.

The new GridColumn element addresses these concerns by
providing a dedicated solution for grouping elements to be
presented in a column layout. It renders a simple div wrapper
with CSS classes for dimensions.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 1

Files 9

Review log 34

  1. Benjamin Kott commented on patch set 1 04/17/25, 10:47

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/17/25, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77886

  3. Benjamin Kott voted on patch set 1 CR +2 V +2 04/17/25, 10:56

  4. Benjamin Kott merged patch set 2 04/17/25, 10:56