Review 13.4 Merged

89158[BUGFIX] Allow to configure RateLimiters in message consumer

Georg Ringer CR +2 V +2 Normal +77 −0 updated 04/22/25, 12:50

Commit message

This fix adds the missing configuration options for the rate limiters.
A "rate limiter" manages the frequency at which a particular messages,
such as an HTTP request or a login attempt, can occur. Rate limiting
serves as a protective mechanism to prevent services from being
overwhelmed by excessive usage, whether intentional or accidental, thus
ensuring their continued availability. Additionally, it proves
beneficial in regulating internal or outbound processes, such as
limiting the simultaneous processing of messages.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Georg Ringer commented on patch set 1 04/17/25, 13:51

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/17/25, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77895

  3. Garvin Hicking commented on patch set 1 04/17/25, 16:52

    Important-103140-AllowToConfigureRateLimiters.rst:14

    "for Symfony Messenger based rate limiters"? I first thought this would apply to login rate limiters or anti spam rate limiters.

    Important-103140-AllowToConfigureRateLimiters.rst:34

    :file:'EXT:...'

    Important-103140-AllowToConfigureRateLimiters.rst:41

    :caption: EXT:yourext/Configuration/Services.yaml? Is this the top/first level of yaml, right?
  4. Garvin Hicking commented on patch set 1 04/17/25, 16:57

    Important-103140-AllowToConfigureRateLimiters.rst:14 Reply

    Oh, I should read on. I always thought symfony messenger is a distinct daemon process. sorry for the noise, I got something to catch up on ;)
  5. Garvin Hicking commented on patch set 1 04/22/25, 06:31

    Adjusted in the main-patch (needs rebase here before merge)

    Important-103140-AllowToConfigureRateLimiters.rst:34 Reply

    Done

    Important-103140-AllowToConfigureRateLimiters.rst:41 Reply

    Done
  6. Benni Mack commented on patch set 2 V +1 04/22/25, 12:33

    Published edit on patch set 1.
  7. core-ci voted on patch set 2 V +1 04/22/25, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78029

  8. Benni Mack voted on patch set 2 CR +2 V +2 04/22/25, 12:50

  9. Benni Mack merged patch set 3 04/22/25, 12:50

  10. Benni Mack commented on patch set 3 04/22/25, 12:50

    Reply

    Done