Review 13.4 Merged

89239[BUGFIX] Always sort items "naturally" in filelist

Andreas Kienast CR +2 V +2 Normal +27 −64 updated 04/25/25, 08:45

Commit message

The collator option `\Collator::NUMERIC_COLLATION` is used to sort its
items in a natural manner as understood by human beings, which is now
always enabled.  Previously, the flag was only used when sorting by file
size.

Additionally, when reversing the result is requested, the calculation is
adjusted to handle this directly in `uksort()`, making the call of
`array_reverse()` obsolete.

Due to the removal of `array_reverse()`, array keys are not reset
anymore, therefore the tests have to use `assertEqualsCanonicalizing()`
as we only care about the correct order of the values. To have _this_
functional, we may not use mocked `ResourceInterface` instances due to
recursion limits.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast commented on patch set 1 04/25/25, 06:54

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/25/25, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78170

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 04/25/25, 08:44

  4. Andreas Kienast merged patch set 2 04/25/25, 08:45