Review 13.4 Merged

89272[BUGFIX] Improve accessibility in sudo-mode modal

Benjamin Franzke CR +2 V +2 Hard +233 −104 updated 05/03/25, 08:44

Commit message

Improve accessibility for password managers by providing the
username field for user password authentication and use our
toplevel module API to cover the entire backend and re-use
our existing modal implementation, including coverage of the
entire backend instead of the module frame only.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 9

Review log 710

  1. Benjamin Franzke commented on patch set 1 04/29/25, 06:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 04/29/25, 06:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78324

  3. Benjamin Franzke marked it work in progress 04/29/25, 06:49

  4. Benjamin Franzke uploaded patch set 2 V -1 04/29/25, 06:50

  5. core-ci voted on patch set 2 V +1 04/29/25, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78328

  6. Benjamin Franzke commented on patch set 3 V +1 04/29/25, 16:37

    Cherry Picked from branch main.
  7. core-ci voted on patch set 3 V +1 04/29/25, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78361

  8. Benjamin Franzke marked it work in progress 04/30/25, 06:28

  9. Benjamin Franzke commented on patch set 3 CR +2 V +2 05/03/25, 08:44

    This change is ready for review.
  10. Benjamin Franzke merged patch set 4 05/03/25, 08:44