Review 12.4 Merged

89380[BUGFIX] Address open_basedir issue in asset path handling

Benni Mack CR +2 V +2 Easy +2 −2 updated 05/13/25, 20:49

Commit message

With #105691, we addressed missing cache busting for absolute
file system paths. Unfortunately, this introduced a regression
if an open_basedir restriction is in effect. This patch fixes that
by ignoring any errors thrown by the introduced `file_exists()`
call. It also prevents duplicate slashes in the generated path.

Since the code isn't present in main anymore, this is only
relevant for 13.4 and 12.4 (original patch has been backported).

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 05/13/25, 20:39

    Cherry Picked from branch 13.4.
  2. core-ci voted on patch set 1 V +1 05/13/25, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78872

  3. Benni Mack voted on patch set 1 CR +2 V +2 05/13/25, 20:49

  4. Benni Mack merged patch set 2 05/13/25, 20:49