Review 13.4 Merged

89653[TASK] Add EXT:styleguide imagemanipulation example file_1

Garvin Hicking CR +2 V +2 Normal +172 −8 updated 06/06/25, 06:30

Commit message

EXT:styleguide currently has three 'sys_file' inputs to enter a file
for the "imagemanipulation" element group.

This is unfortunate, because no file picker can be used here, records
need to be entered by UID. Due to type=group & allowed=sys_file,
the record selector yields no file tree or records.

To ease this up for testing, a new "file_1" column has been
introduced, which also now showcases inline cropVariant configs
via TCA childOverride. This was not covered yet and repesents
a commonly used practice in integrations. The TCA
override only covers the crop configuration to be applied in
FormEngine context, DataHandler does not need to deal with
this at this place.

As a drive-by change, the "tall" crop config is enlarged a bit
to make testing easier, because it easily created way too small
aspect crop areas.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 3

Files 1

Review log 34

  1. Garvin Hicking commented on patch set 1 06/06/25, 05:56

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/06/25, 06:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79966

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 06/06/25, 06:30

  4. Garvin Hicking merged patch set 2 06/06/25, 06:30