Review main Merged

89712[TASK] Cleanup selected items in `CompareUserCest`

Stefan Bürk CR +2 V +2 Easy +17 −0 updated 06/12/25, 11:48

Commit message

With #98070, acceptance test data providers have been removed,
resulting in a different split package constellation depending
on the selected split count, which differs between pre-merge and
nightly execution.

This has now revealed that `CompareUserCest` selects users and
user groups to test edit and comparison views without clearing
them, and it is executed before `ListGroupCest`, which does not
expect comparison selections and uses the wrong table for its
test assumptions.

This change clears the selected items by resetting the lists
in CompareUserCest instead of adjusting the selectors in
ListGroupCest, to avoid future test failures when both cests
are split into dedicated packages again.

[1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/88852

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1014

  1. Stefan Bürk uploaded patch set 1 06/12/25, 10:05

  2. Stefan Bürk updated the commit message in patch set 2 06/12/25, 10:05

  3. core-ci voted on patch set 1 V +1 06/12/25, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80241

  4. core-ci voted on patch set 2 V +1 06/12/25, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80242

  5. core-ci commented on patch set 2 06/12/25, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80244

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 06/12/25, 10:45

  7. Simon Schaufelberger commented on patch set 2 06/12/25, 10:51

    typo
    some typos in the commit message
  8. Stefan Bürk updated the commit message in patch set 3 CR +1 V +1 06/12/25, 11:27

  9. Stefan Bürk commented on patch set 3 06/12/25, 11:28

    Reply

    Done

    Reply

    Done
  10. Anja Leichsenring voted on patch set 3 CR +1 V +1 06/12/25, 11:30

  11. Christian Kuhn voted on patch set 3 CR +1 V +1 06/12/25, 11:32

  12. core-ci voted on patch set 3 V +1 06/12/25, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80246

  13. Stefan Bürk voted on patch set 3 CR +2 V +2 06/12/25, 11:35

  14. Stefan Bürk merged patch set 4 06/12/25, 11:48